tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Howard M. Lewis Ship (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (TAP5-1941) Alerts component can fail with
Date Fri, 01 Aug 2014 17:23:39 GMT

     [ https://issues.apache.org/jira/browse/TAP5-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Howard M. Lewis Ship updated TAP5-1941:

    Summary: Alerts component can fail with   (was: Alerts component should check for XHR
request in "dismiss" event handler)

> Alerts component can fail with 
> -------------------------------
>                 Key: TAP5-1941
>                 URL: https://issues.apache.org/jira/browse/TAP5-1941
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.3
>            Reporter: Felix Gonschorek
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.4
> The Alerts component does not check for request.isXHR() in the "onDismiss" event handler.

> Crawlers (Googlebot) send non-xhr requests to the "onDismiss" event-url and generate
errors on my server, because the returned JSONObject is not a valid return value from an event
> org.apache.tapestry5.runtime.ComponentEventException: A component event handler method
returned the value {}. Return type org.apache.tapestry5.json.JSONObject can not be handled.

> A check for request.isXHR() and a conditional return value (null for non-ajax requests,
the json object for ajax requests) should fix this.
> thanks!

This message was sent by Atlassian JIRA

View raw message