tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1941) Alerts component can fail with ComponentEventException is dismiss event triggered outside of XHR request (e.g., by web crawler)
Date Fri, 01 Aug 2014 19:11:39 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082774#comment-14082774
] 

Hudson commented on TAP5-1941:
------------------------------

ABORTED: Integrated in tapestry-trunk-freestyle #1292 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1292/])
TAP5-1941: Alerts component can fail with ComponentEventException is dismiss event triggered
outside of XHR request (e.g., by web crawler) (hlship: rev 0d3c9bc950adcf837ae4378e2efe490763cc10fa)
* tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Alerts.java


> Alerts component can fail with ComponentEventException is dismiss event triggered outside
of XHR request (e.g., by web crawler)
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1941
>                 URL: https://issues.apache.org/jira/browse/TAP5-1941
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.3
>            Reporter: Felix Gonschorek
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.4
>
>
> The Alerts component does not check for request.isXHR() in the "onDismiss" event handler.

> Crawlers (Googlebot) send non-xhr requests to the "onDismiss" event-url and generate
errors on my server, because the returned JSONObject is not a valid return value from an event
handler.
> org.apache.tapestry5.runtime.ComponentEventException: A component event handler method
returned the value {}. Return type org.apache.tapestry5.json.JSONObject can not be handled.

> A check for request.isXHR() and a conditional return value (null for non-ajax requests,
the json object for ajax requests) should fix this.
> thanks!



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message