tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jochen Kemnade (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-2029) Copy annotations from service implementation to proxy (was JPA annotations expose implementation details in service interfaces)
Date Thu, 16 Jul 2015 07:38:04 GMT

    [ https://issues.apache.org/jira/browse/TAP5-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629366#comment-14629366
] 

Jochen Kemnade commented on TAP5-2029:
--------------------------------------

[~thiagohp], I think you may have forgotten to commit {{org.apache.tapestry5.ioc.internal.NonAnnotatedGenericSetServiceInterface}}
and {{org.apache.tapestry5.ioc.internal.NonAnnotatedGenericSetServiceImpl}}.

> Copy annotations from service implementation to proxy (was JPA annotations expose implementation
details in service interfaces)
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-2029
>                 URL: https://issues.apache.org/jira/browse/TAP5-2029
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3.6, 5.4
>            Reporter: John Coleman
>            Assignee: Thiago H. de Paula Figueiredo
>            Priority: Minor
>              Labels: month-of-tapestry
>             Fix For: 5.4
>
>         Attachments: 0001-TAP5-2029-Test-case-involving-generic-interface.patch
>
>
> The commit after and persistence context annotations are required on the service interface
definition thereby exposing internal implementation details (see below example from docs).
Details of implementation should be hidden at the interface level, both these annotations
break the rule.
> Perhaps this code could appear in the Impl classes, or be provided in configuration somehow?
> public interface UserDAO {
>    @CommitAfter
>    @PersistenceContext(unitName = "DemoUnit")
>    void add(User user);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message