tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jochen Kemnade (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1874) OperationTracker description logging improvement
Date Fri, 07 Aug 2015 09:54:46 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661570#comment-14661570
] 

Jochen Kemnade commented on TAP5-1874:
--------------------------------------

Yes, but we wouldn't need to create a new class for each description if we provide classes
that use a MessageFormat or a CharSequence subclass that formats the String lazily. But we
could also wait for Java8 and add default methods to the OperationTracker interface. We can
then override them in OperationTrackerImpl and delegate from the String variants.

> OperationTracker description logging improvement
> ------------------------------------------------
>
>                 Key: TAP5-1874
>                 URL: https://issues.apache.org/jira/browse/TAP5-1874
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3, 5.4
>            Reporter: Denis Stepanov
>            Priority: Minor
>
> I like the concept of the OperationTracker, but it would be nice if the operation's description
was created only when it's needed. Most of the tapestry code creates the description using
the string concatenating or String.format all the time, but it is only used when an error
occurs or the debug logging is enabled.
> I would suggest to create new interface Operation/OperationInvokable with getDescription
method as the replacement of Runnable/Invokable interface:
>   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message