tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kalle Korhonen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1803) URL encoding in ActivationRequestParameter is very strict
Date Mon, 14 Mar 2016 20:47:33 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194095#comment-15194095
] 

Kalle Korhonen commented on TAP5-1803:
--------------------------------------

Replacing the URLEncoderImpl with a custom implementation has been one of the first tasks
in most real world projects I've been involved in - the built-in one really doesn't give a
reasonable default behavior IMHO. I agree with Jochen, just skipping the safe set check when
decoding seem like a good, common sense improvement. 

> URL encoding in ActivationRequestParameter is very strict
> ---------------------------------------------------------
>
>                 Key: TAP5-1803
>                 URL: https://issues.apache.org/jira/browse/TAP5-1803
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.1, 5.4
>            Reporter: David Canteros
>              Labels: @ActivationRequestParameter, InvalidaArgumenteException, URLEncoder,
>
> The URLEncoder that perform the URL encoding process does not include the following "unreserved
characters" : 	 
>  !  ~  *  ' (  )	 
> (see rfc2396 Uniform Resource Identifiers (URI): Generic Syntax, item 2.3)
> 	 
> Because the fix of TAP5-1768, from v5.3.1 the @ActivationRequestParameter requires this
enconding, which becomes incompatible with the standard.
> Thus, any URL which contains those symbols will throw an InvalidaArgumenteException.
Tapestry should consider that the ActivationRequestParameter is a standar way of parameter
sending, and the parameters sent in this way probably not have the "strict" coding process
of the URLEncoder.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message