tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kalle Korhonen <kalle.o.korho...@gmail.com>
Subject Re: TAP5 (Support pseudo nested JPA transactions) merged
Date Fri, 10 Jun 2016 06:11:33 GMT
On Thu, Jun 9, 2016 at 3:40 PM, Thiago H de Paula Figueiredo <
thiagohp@gmail.com> wrote:

> On Wed, 08 Jun 2016 15:02:30 -0300, Kalle Korhonen <
> kalle.o.korhonen@gmail.com> wrote:
>
>> I just pushed a new JPA feature for T5.5, see
>>
>> https://github.com/apache/tapestry5/commit/5047220cfe9a6f8a640fb10f0e3de266af51630f
>> .
>> There's one issue though - I had to add annotations to a test service
>> *interface* (UserDAO) to make one test, specifically
>> JpaIntegrationTestWithAnnotationsInServiceImplementation work. I'm really
>> not sure why at this point but I wanted to push it now for all to take a
>> look at. I'm pretty sure it has something to do with the advice
>> implementation, what's wrong with
>>
>> https://github.com/apache/tapestry5/blob/master/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/JpaTransactionAdvisorImpl.java
>> ?
>>
> Weird, the annotation copying from service implementation to proxy has a
> lot of unit tests covering a lot of cases, including some corner ones that
> were filed by users.


I've been doing this long enough that I know the likeliest source of a bug
is in my own code :) Just didn't see one now but oh well, I'll dig it out.

>
> Additionally, are you guys able to run the Selenium integrations
>> successfully from the IDE? I am not, not sure why and it makes it awfully
>> hard to debug.
>>
> Selenium is discontinued as far as I know.


What? That's news to me, can you provide a reference? I tell you, so many
parts of Tapestry are so elegant, but testing both with Easymock and
Selenium sometimes feels arcane to me compared to Geb, Mockito and HtmlUnit
(and no, not signing up to rewrite the 1500 tests we have...).

Kalle

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message