tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kao...@apache.org
Subject tapestry-5 git commit: TAP5-2554: Using Confirm mixin in conjunction with an EventLink or ActionLink having "async" set to true causes double invocation of event handler
Date Fri, 08 Jul 2016 20:38:30 GMT
Repository: tapestry-5
Updated Branches:
  refs/heads/master 0f4f1f872 -> d8120525e


TAP5-2554:  Using Confirm mixin in conjunction with an EventLink or
ActionLink having "async" set to true causes double invocation of event
handler

- apply patch from
https://patch-diff.githubusercontent.com/raw/apache/tapestry-5/pull/4.patch
without changes

Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/d8120525
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/d8120525
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/d8120525

Branch: refs/heads/master
Commit: d8120525e858fa600ec6e2d8fbcb86188c1155f7
Parents: 0f4f1f8
Author: kaosko <kaosko@apache.org>
Authored: Fri Jul 8 13:38:26 2016 -0700
Committer: kaosko <kaosko@apache.org>
Committed: Fri Jul 8 13:38:26 2016 -0700

----------------------------------------------------------------------
 .../coffeescript/META-INF/modules/t5/core/confirm-click.coffee | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d8120525/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/confirm-click.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/confirm-click.coffee
b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/confirm-click.coffee
index 8043445..dd3c9f3 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/confirm-click.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/confirm-click.coffee
@@ -82,14 +82,10 @@ define ["jquery", "./events", "bootstrap/modal"],
       # Cancel the original click event
       return false
 
-    ($ document).on "click", "a[data-confirm-message]:not(.disabled)", (event) ->
+    ($ document).on "click", "a[data-confirm-message]:not(.disabled, [data-update-zone],
[data-async-trigger])", (event) ->
 
       target = $ event.target
 
-      # Order of event handlers on an element is not predictable. From testing, I found this
could happen.
-      # A bit ugly.
-      return if target.attr "data-update-zone"
-
       # See note above; this replicates the default behavior of a link element that is lost
because
       # of the
       window.location.href = target.attr "href"


Mime
View raw message