tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1493) Property expressions on properties that are covariant on a base class use the type of the base class property, not the covariant subclass
Date Thu, 14 Jul 2016 08:17:20 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376547#comment-15376547
] 

Hudson commented on TAP5-1493:
------------------------------

FAILURE: Integrated in tapestry-trunk-freestyle #1584 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1584/])
TAP5-2449, TAP5-1493: add the interfaces to the queue in the correct (jkemnade: rev c2a4b9698993334368359bab2139f4a95a1e56d6)
* beanmodel/src/main/java/org/apache/tapestry5/ioc/internal/services/PropertyAccessImpl.java


> Property expressions on properties that are covariant on a base class use the type of
the base class property, not the covariant subclass
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1493
>                 URL: https://issues.apache.org/jira/browse/TAP5-1493
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core, tapestry-ioc
>    Affects Versions: 5.2
>            Reporter: Howard M. Lewis Ship
>            Assignee: Thiago H. de Paula Figueiredo
>            Priority: Critical
>              Labels: month-of-tapestry
>             Fix For: 5.4
>
>
> public abstract class AbstractFoo
> {
>  public abstract AbstractBar getBar();
> }
> public class Foo extends AbstractFoo
> {
>  public Bar getBar();
> }
> Here property bar is covariant; the subclass (Foo) changes the type of the return value
(from AbstractBar to just Bar). Assuming that Bar is a subclass of AbstractBar, that's fine.
> The bug is that in this circumstance, the PropertyConduitSource sees the type of
> property "bar" of class Foo as AbstractBar, not Bar.
> Interestingly, a little debugging showed that the getter method for property bar was
"public AbstractBar Foo.getBar()" ... in other words, much like with Generics, covariant return
types may be largely
> a fiction of the compiler inserting the necessary casts in place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message