tez-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Eagles <jeag...@gmail.com>
Subject Re: Pre-commit checks before committing a patch
Date Wed, 21 Jan 2015 03:07:15 GMT
Thanks for this effort Hitesh. Very good for the community

On Tue, Jan 20, 2015 at 6:23 PM, Hitesh Shah <hitesh@apache.org> wrote:
> A follow-up on the findbugs warnings. From now on, the findbugs counter should be 0.
TEZ-316 tracks all the various issues that need to be fixed to get to a real 0 value but for
now, these known issues have been suppressed.
> If the pre-commit build shows a non-zero value, please do watch out for that as this
means a new warning has been introduced.
> thanks
> — Hitesh
> On Jan 13, 2015, at 11:03 AM, Hitesh Shah <hitesh@apache.org> wrote:
>> Hi folks
>> Looks like the pre-commit build has been setup. Moving forwards, all patches need
to get a green light from the pre-commit build before they can be committed.
>> For a short period while the old findbugs issues are being fixed, the findbugs warnings
can be ignored. However, please do keep an eye on the regular value ( currently looks like
it is 260 ) and ensure that the new patch does not increase this count.
>> thanks
>> — Hitesh

View raw message