tez-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bjmb <...@git.apache.org>
Subject [GitHub] tez pull request #22: [WIP][TEZ-3904] An API to update tokens for Tez AM and...
Date Thu, 14 Jun 2018 00:00:33 GMT
Github user bjmb commented on a diff in the pull request:

    https://github.com/apache/tez/pull/22#discussion_r195270418
  
    --- Diff: tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java
---
    @@ -160,14 +161,15 @@
       private final boolean initializeProcessorFirst;
       private final boolean initializeProcessorIOSerially;
       private final TezExecutors sharedExecutor;
    +  private final SystemEventHandler systemEventHandler;
     
       public LogicalIOProcessorRuntimeTask(TaskSpec taskSpec, int appAttemptNumber,
           Configuration tezConf, String[] localDirs, TezUmbilical tezUmbilical,
           Map<String, ByteBuffer> serviceConsumerMetadata, Map<String, String>
envMap,
           Multimap<String, String> startedInputsMap, ObjectRegistry objectRegistry,
           String pid, ExecutionContext ExecutionContext, long memAvailable,
           boolean updateSysCounters, HadoopShim hadoopShim,
    -      TezExecutors sharedExecutor) throws IOException {
    +      TezExecutors sharedExecutor, SystemEventHandler systemEventHandler) throws IOException
{
    --- End diff --
    
    This API changes, this is bad?


---

Mime
View raw message