tez-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yingdachen <...@git.apache.org>
Subject [GitHub] tez issue #33: TEZ-3998: support constructing DAG with concurrent edge
Date Wed, 17 Oct 2018 00:58:58 GMT
Github user yingdachen commented on the issue:

    https://github.com/apache/tez/pull/33
  
    > @yingdachen since this is part of a larger end-to-end feature (Tez-3997) would it
be better for you to own a feature branch, in which you commit for the subtasks, and later,
when the feature is complete, merge into master?
    > It is easier to provide meaningful feedback when seeing how it all comes together
- right now, most of the changes are stubs.
    
    @anicoara thanks for the feedback.
    
    couple of things
    
    1. The design doc in 3997 was meant to provide the big picture and as the place to collect
feedback for the overall design. We believe suitable level of details about proposed changes
have been provided, and it would be great hear from community on the design.
    
    2. The feature was broken into 4 tasks carefully that range from basic support and plugin
addition(3998), api change in AM component (3999), change in runtime (4000) and more complete
scenario support (4001). We believe such break-down is suitable for us as new contributors
to fit in, beginning with a simple change discussed here (3998) that is standalone in itself.
We are hoping that our changes will take a gradual path to completion, which would not necessitate
a separate feature branch.
    
    3. In the change introduced here, the SilentEdgeManager is indeed a stub, that is by design
and would not likely to change. However, I would not categorize the other change (such as
the new VertexManagerWithConcurrentInput) as so, since it is functional as it is and we have
added UT coverage to cover that as well.
    



---

Mime
View raw message