tez-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jteagles <...@git.apache.org>
Subject [GitHub] tez pull request #33: TEZ-3998: support constructing DAG with concurrent edg...
Date Fri, 19 Oct 2018 20:17:13 GMT
Github user jteagles commented on a diff in the pull request:

    https://github.com/apache/tez/pull/33#discussion_r226706087
  
    --- Diff: tez-api/src/main/java/org/apache/tez/dag/api/DAG.java ---
    @@ -79,16 +79,16 @@
     import com.google.common.collect.Sets;
     
     /**
    - * Top level entity that defines the DAG (Directed Acyclic Graph) representing 
    --- End diff --
    
    Usually for formatting changes we submit a separate change to address the whitespace changes
to keep the logic  changes separate to ease the review. Many editors default to automatically
fix trailing whitespace on save and hadoop developers tend to disable this feature. Github
allows me to hide whitespace changes so this is not much of a big deal.


---

Mime
View raw message