tez-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jteagles <...@git.apache.org>
Subject [GitHub] tez pull request #33: TEZ-3998: support constructing DAG with concurrent edg...
Date Fri, 19 Oct 2018 20:17:13 GMT
Github user jteagles commented on a diff in the pull request:

    https://github.com/apache/tez/pull/33#discussion_r226769441
  
    --- Diff: tez-runtime-library/src/test/java/org/apache/tez/dag/library/vertexmanager/TestVertexManagerWithConcurrentInput.java
---
    @@ -0,0 +1,114 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tez.dag.library.vertexmanager;
    +
    +import org.apache.tez.dag.api.EdgeManagerPluginDescriptor;
    +import org.apache.tez.dag.api.EdgeProperty;
    +import org.apache.tez.dag.api.InputDescriptor;
    +import org.apache.tez.dag.api.OutputDescriptor;
    +import org.apache.tez.dag.api.VertexManagerPluginContext;
    +import org.apache.tez.dag.api.VertexManagerPluginDescriptor;
    +import org.apache.tez.dag.api.event.VertexState;
    +import org.apache.tez.dag.api.event.VertexStateUpdate;
    +import org.apache.tez.dag.library.edgemanager.SilentEdgeManager;
    +import org.junit.Assert;
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.mockito.ArgumentCaptor;
    +import org.mockito.Captor;
    +import org.mockito.MockitoAnnotations;
    +
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.List;
    +
    +import static org.mockito.Mockito.mock;
    +import static org.mockito.Mockito.times;
    +import static org.mockito.Mockito.verify;
    +import static org.mockito.Mockito.when;
    +
    +public class TestVertexManagerWithConcurrentInput {
    +
    +  @Captor
    +  ArgumentCaptor<List<VertexManagerPluginContext.ScheduleTaskRequest>> requestCaptor;
    +
    +  @Before
    +  public void init() {
    +    MockitoAnnotations.initMocks(this);
    +  }
    +
    +  @Test//(timeout=5000)
    --- End diff --
    
    Perhaps timeout should be uncommented
    ```suggestion
      @Test(timeout=5000)
    ```


---

Mime
View raw message