tez-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yingdachen <...@git.apache.org>
Subject [GitHub] tez pull request #33: TEZ-3998: support constructing DAG with concurrent edg...
Date Thu, 08 Nov 2018 22:21:14 GMT
Github user yingdachen commented on a diff in the pull request:

    https://github.com/apache/tez/pull/33#discussion_r232082409
  
    --- Diff: tez-api/src/main/java/org/apache/tez/dag/api/TezConfiguration.java ---
    @@ -408,6 +409,18 @@ public TezConfiguration(boolean loadDefaults) {
           + "launch.env";
       public static final String TEZ_AM_LAUNCH_ENV_DEFAULT = "";
     
    +  /**
    +   * String value. Describes the timing of scheduling downstream vertex tasks
    +   * when the vertex has a concurrent input edge.
    --- End diff --
    
    I have expand the comment a bit in an effort to make it easier to understand. 
    
    Not using the event name directly is due to the subtle difference between event and scheduling
actually being kicked off: for example, in the case of "SOURCE_TASK_STARTED", the scheduling
is not triggered by any TASK_STARTED event, but instead it will only be triggered after enough
TASK_STARTED events have been collected (for example, all the upstream tasks are running).
For the lack of a better choice, I think defining a TriggerType is easier to expand in the
long run too.


---

Mime
View raw message