tez-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From beltran <...@git.apache.org>
Subject [GitHub] tez pull request #33: TEZ-3998: support constructing DAG with concurrent edg...
Date Thu, 08 Nov 2018 23:45:43 GMT
Github user beltran commented on a diff in the pull request:

    https://github.com/apache/tez/pull/33#discussion_r232100045
  
    --- Diff: tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java ---
    @@ -2440,23 +2453,30 @@ public void run() {
         }
       }
     
    -  private void startDAG() throws IOException, TezException {
    +  private boolean hasConcurrentEdge(DAGPlan dagPlan) {
    +    boolean hasConcurrentEdge = false;
    +    for (DAGProtos.EdgePlan edge : dagPlan.getEdgeList()) {
    +      if (DAGProtos.PlanEdgeSchedulingType.CONCURRENT.equals(edge.getSchedulingType()))
{
    +        return true;
    +      }
    +    }
    +    return hasConcurrentEdge;
    +  }
    +
    +  private DAGPlan readDAGPlanFile() throws IOException, TezException {
         FileInputStream dagPBBinaryStream = null;
    +    DAGPlan dagPlan = null;
         try {
    -      DAGPlan dagPlan = null;
    -
           // Read the protobuf DAG
           dagPBBinaryStream = new FileInputStream(new File(workingDirectory,
               TezConstants.TEZ_PB_PLAN_BINARY_NAME));
           dagPlan = DAGPlan.parseFrom(dagPBBinaryStream);
    -
    -      startDAG(dagPlan, null);
    --- End diff --
    
    Oh yes, just saw there are two lines like that. I was referring to the one in 1993. So
before when `startDAG` was called and then got into 1993 it had no effect?


---

Mime
View raw message