tez-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jteagles commented on a change in pull request #37: TEZ-4042: Speculative attempts should avoid running on the same node
Date Fri, 22 Feb 2019 05:50:00 GMT
jteagles commented on a change in pull request #37: TEZ-4042: Speculative attempts should avoid
running on the same node
URL: https://github.com/apache/tez/pull/37#discussion_r259215452
 
 

 ##########
 File path: tez-dag/src/main/java/org/apache/tez/dag/app/dag/TaskAttempt.java
 ##########
 @@ -136,4 +137,5 @@ public void setLocalityCounter(DAGCounter localityCounter) {
    */
   long getFinishTime();
 
+  Set<NodeId> getUnhealthyNodesHistory();
 
 Review comment:
   It would be better to find a better name than "unhealthy". We are really trying to enforce
negative affinity for a node, the concept of trying to avoid the same node in case the node
is slow for some reason. Many times the original, non-speculative task finishes first. Maybe
some better name you can think of.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message