tez-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tez] yingdachen commented on a change in pull request #41: TEZ-4062. Speculative attempt scheduling should be aborted when Task has completed.
Date Mon, 22 Apr 2019 05:32:56 GMT
yingdachen commented on a change in pull request #41: TEZ-4062. Speculative attempt scheduling
should be aborted when Task has completed.
URL: https://github.com/apache/tez/pull/41#discussion_r277209240
 
 

 ##########
 File path: tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestTaskImpl.java
 ##########
 @@ -982,6 +982,23 @@ public void testSpeculatedThenRetroactiveFailure() {
     Assert.assertEquals(mockDestId, newAttempt.getSchedulingCausalTA());
   }
 
+  @Test(timeout = 20000)
+  public void testIgnoreSpeculation() {
+    TezTaskID taskId = getNewTaskID();
+    scheduleTaskAttempt(taskId);
+    MockTaskAttemptImpl firstAttempt = mockTask.getLastAttempt();
+    launchTaskAttempt(firstAttempt.getID());
+    // Have the first task succeed
+    updateAttemptState(firstAttempt, TaskAttemptState.SUCCEEDED);
+    firstAttempt.handle(new TaskAttemptEvent(firstAttempt.getID(), TaskAttemptEventType.TA_DONE));
+
+    // Ignore speculation
 
 Review comment:
   // verify the speculation scheduding is ignored and no speculative attempt was added to
the task

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message