tez-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tez] yingdachen commented on a change in pull request #42: TEZ-4068: Prevent new speculative attempt after task has issued canCo…
Date Fri, 10 May 2019 09:30:15 GMT
yingdachen commented on a change in pull request #42: TEZ-4068: Prevent new speculative attempt
after task has issued canCo…
URL: https://github.com/apache/tez/pull/42#discussion_r282812495
 
 

 ##########
 File path: tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/TaskImpl.java
 ##########
 @@ -1043,6 +1043,10 @@ public void transition(TaskImpl task, TaskEvent event) {
         LOG.info("Ignore speculation scheduling since there is no running attempt on task
{}.", task.getTaskId());
         return;
       }
+      if (task.commitAttempt != null) {
+        LOG.info("Ignore speculation scheduling since there is commitAttempt on task {}.",
task.commitAttempt);
 
 Review comment:
   LOG.info("Ignore speculation scheduling for task {} since commit has started with commitAttempt
{}.", task.getTaskId, task.commitAttempt);

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message