thrift-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satoshi Tagomori <tagomo...@gmail.com>
Subject Re: Javascript variable scope
Date Thu, 09 Jan 2014 11:52:56 GMT
Hi Henrique,

Thank you for your reply! I see why that patch have not been merged.
Of course I know about namespace, but I want to get good code from thrift.

I'll try to make patch that works and doesn't break tests later.


2014/1/9 Henrique Mendonça <henrique@apache.org>

> Hi Satoshi,
>
> it breaks the unit tests, so it can't be merged!
> Are you using a namespace? That would probably solve you problem.
>
> - Henrique
>
>
> On 9 January 2014 09:29, Satoshi Tagomori <tagomoris@gmail.com> wrote:
>
> > Hi,
> >
> > I'm user of thrift for node.js, and I have troubles about variable scopes
> > of
> > generated node.js code by thrift-0.9.1.
> >
> > I found this issue, but this patch is not merged yet.
> >
> > https://issues.apache.org/jira/browse/THRIFT-1840
> >
> > This issue is forgotten? Or any other reasons?
> > --
> > tagomoris (TAGOMORI Satoshi)
> > Mail: tagomoris@gmail.com
> >
>



-- 
田籠 聡 (TAGOMORI Satoshi)
Mail: tagomoris@gmail.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message