tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith R. Bennett (JIRA)" <j...@apache.org>
Subject [jira] Updated: (TIKA-29) Exceptions are being swallowed that need to be thrown.
Date Tue, 25 Sep 2007 01:09:50 GMT

     [ https://issues.apache.org/jira/browse/TIKA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Keith R. Bennett updated TIKA-29:
---------------------------------

    Attachment: tika-29-diag.patch

All -

I've marked some questionable catch clauses with:

// Swallowed exception

Here is the distribution by file:

mime/MimeTypesReader.java:3
mime/MimeUtils.java:2
parser/html/HtmlParser.java:1
parser/msexcel/MsExcelParser.java:2
parser/mspowerpoint/ContentReaderListener.java:4
parser/mspowerpoint/MsPowerPointParser.java:2
parser/msword/MsWordParser.java:2
parser/opendocument/OpenOfficeParser.java:4
parser/pdf/PDFParser.java:6
parser/rtf/RTFParser.java:3
parser/txt/TXTParser.java:4
parser/xml/XMLParser.java:3
utils/MSExtractor.java:1
utils/Utils.java:4

I tried to omit the legitimate cases, but there may be some false positives.

Attached is a patch file that, when applied, will insert the comments in their proper places
to the build I checked out a few hours ago (revision #578987 I believe).

Regards,
Keith




> Exceptions are being swallowed that need to be thrown.
> ------------------------------------------------------
>
>                 Key: TIKA-29
>                 URL: https://issues.apache.org/jira/browse/TIKA-29
>             Project: Tika
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Priority: Critical
>             Fix For: 0.1-incubator
>
>         Attachments: tika-29-diag.patch
>
>
> There are many cases in several classes where exceptions are being swallowed where they
should be thrown instead.
> It is important that the caller be notified of an error if one occurs.  The caller needs
the opportunity to record the failure and set aside the document for future processing, or
whatever else needs to be done in case of error.
> I'm marking this critical because we have no way of knowing the importance of the missing
data; it could be of the utmost importance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message