tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting" <jukka.zitt...@gmail.com>
Subject Re: svn commit: r582674 - in /incubator/tika/trunk: ./ src/main/java/org/apache/tika/config/ src/main/java/org/apache/tika/parser/ src/main/java/org/apache/tika/parser/html/ src/main/java/org/apache/tika/parser/msexcel/ src/main/java/org/apache/tika/
Date Sun, 07 Oct 2007 20:40:33 GMT
Hi,

On 10/7/07, Chris Mattmann <chris.mattmann@jpl.nasa.gov> wrote:
> On 10/7/07 1:01 PM, "jukka@apache.org" <jukka@apache.org> wrote:
> > --- incubator/tika/trunk/src/main/java/org/apache/tika/utils/ParseUtils.java
> > (original)
> > +++ incubator/tika/trunk/src/main/java/org/apache/tika/utils/ParseUtils.java
>
> I'm not sure I get these changes for this file: did you just remove it and
> add it back? Was it formatting that changed?

Good catch. It turns out that the file didn't have svn:eol-style set,
so when I saved it on Windows all the line endings were changed. Sorry
about that... I set the svn:eol-style property to native in revision
582677.

> > Modified: incubator/tika/trunk/src/test/java/org/apache/tika/TestParsers.java
> > URL:
> > http://svn.apache.org/viewvc/incubator/tika/trunk/src/test/java/org/apache/tik
> > a/TestParsers.java?rev=582674&r1=582673&r2=582674&view=diff
> > ==============================================================================
> > --- incubator/tika/trunk/src/test/java/org/apache/tika/TestParsers.java
> > (original)
> > +++ incubator/tika/trunk/src/test/java/org/apache/tika/TestParsers.java Sun
>
> > -        assertEquals("Sample Powerpoint Slide", contents.get("title")
> > -                .getValue());
> > +        assertEquals("Sample Powerpoint Slide", metadata.get("title"));
>
> Your commit didn't include my updates to the above, which changed it to use
> Metadata.TITLE, instead of the literal string "title"

Ah, thanks. The patch failed to apply for TestParsers.java (probably
because of my intervening changes), so I just manually reapplied my
changes. I'll commit your improvements.

BR,

Jukka Zitting

Mime
View raw message