tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fabian Lange (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TIKA-838) EmptyParser Singleton should be final
Date Tue, 03 Jan 2012 18:04:46 GMT

    [ https://issues.apache.org/jira/browse/TIKA-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178876#comment-13178876

Fabian Lange commented on TIKA-838:

Hi Nick, 
clirr is correct. The public API currently is that every client can write to this field.
But clients currently doing so are possibly dangerous to others in a shared classpath environment.
This is a singleton (at least according to the comment :-)) and it should be coded as this:

But if you cant break broken backwards compatibility, then this cannot be fixed.
Let me know if I can do something about it. Otherwise feel also free to close this ticket.

> EmptyParser Singleton should be final
> -------------------------------------
>                 Key: TIKA-838
>                 URL: https://issues.apache.org/jira/browse/TIKA-838
>             Project: Tika
>          Issue Type: Sub-task
>          Components: general
>            Reporter: Fabian Lange
>         Attachments: EmptyParser.java.patch
> Currently the Singleton EmptyParser is not a robust singleton. Other Code could possibly
exchange it, as it is not marked final.
> This might pose a security risk.
> Additionally, because the value is not final, the JVM cannot optimize it.
> Attached patch adds the final attribute.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message