tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej Bialecki (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TIKA-863) MailContentHandler should not create AutoDetectParser on each call
Date Fri, 17 Feb 2012 12:47:59 GMT

    [ https://issues.apache.org/jira/browse/TIKA-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210221#comment-13210221
] 

Andrzej Bialecki  commented on TIKA-863:
----------------------------------------

I see your point, it makes sense - no hidden surprises. However, I think the part of the patch
that simply checks whether an existing AutoDetectParser has been provided and uses it if present,
is still useful and makes a huge difference.
                
> MailContentHandler should not create AutoDetectParser on each call
> ------------------------------------------------------------------
>
>                 Key: TIKA-863
>                 URL: https://issues.apache.org/jira/browse/TIKA-863
>             Project: Tika
>          Issue Type: Bug
>          Components: parser
>    Affects Versions: 1.1
>            Reporter: Andrzej Bialecki 
>         Attachments: TIKA-863.patch
>
>
> MailContentHandler is called from RFC822Parser, and it creates AutoDetectParser on each
call to parse(...). The process of creating AutoDetectParser involves reading TikaConfig (not
cached), which in turn involves parsing XML config files. Apart from the fact that this process
is wasteful and heavy, in addition in a highly concurrent setup it leads to multiple threads
blocking on SAX parser creation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message