tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maciej Lizewski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TIKA-1145) classloaders issue loading resources when extending Tika
Date Thu, 04 Jul 2013 08:02:20 GMT

    [ https://issues.apache.org/jira/browse/TIKA-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699840#comment-13699840
] 

Maciej Lizewski commented on TIKA-1145:
---------------------------------------

I would rather suggest opposite - ServiceLoader is properly using the classloader provided
in TikaConfig (ServiceLoader is instantiated in TikaConfig::init() and classloader configured
in TikaConfig is passed to ServiceLoader and stored in loader attribute). This part works
as expected - uses provided classLoader.

Problem is with MimeTypesFactory which ignores classLoader from TikaConfig and always is using:
ClassLoader cl = MimeTypesReader.class.getClassLoader();

which is wrong in case user provided custom classLoader.
                
> classloaders issue loading resources when extending Tika
> --------------------------------------------------------
>
>                 Key: TIKA-1145
>                 URL: https://issues.apache.org/jira/browse/TIKA-1145
>             Project: Tika
>          Issue Type: Bug
>          Components: config, mime
>    Affects Versions: 1.3
>         Environment: Tika as part of standard Solr distribution
>            Reporter: Maciej Lizewski
>
> I noticed that ServiceLoader is using different classloader when loading 'services' like
Parsers, etc (java.net.FactoryURLClassLoader) than MimeTypesFactory (org.eclipse.jetty.webapp.WebAppClassLoader)
when loading mime types definitions. As result - it works completely different:
> When jar with custom parser and custom-mimetypes.xml is added to solr.war - both resources
are located and loaded (META-INF\services\org.apache.tika.parser.Parser and org\apache\tika\mime\custom-mimetypes.xml)
and everything works fine.
> When jar with custom parser is in Solr core lib and configured in solrconfig.xml - only
META-INF\services\org.apache.tika.parser.Parser is loaded, but custom-mimetypes.xml is ignored.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message