From dev-return-12531-apmail-tika-dev-archive=tika.apache.org@tika.apache.org Wed Aug 6 19:22:14 2014 Return-Path: X-Original-To: apmail-tika-dev-archive@www.apache.org Delivered-To: apmail-tika-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 900C111059 for ; Wed, 6 Aug 2014 19:22:14 +0000 (UTC) Received: (qmail 27130 invoked by uid 500); 6 Aug 2014 19:22:14 -0000 Delivered-To: apmail-tika-dev-archive@tika.apache.org Received: (qmail 27099 invoked by uid 500); 6 Aug 2014 19:22:14 -0000 Mailing-List: contact dev-help@tika.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tika.apache.org Delivered-To: mailing list dev@tika.apache.org Received: (qmail 27074 invoked by uid 99); 6 Aug 2014 19:22:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Aug 2014 19:22:14 +0000 Date: Wed, 6 Aug 2014 19:22:14 +0000 (UTC) From: "Uwe Schindler (JIRA)" To: dev@tika.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Reopened] (TIKA-1387) Add forbidden-apis checker to TIKA build MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TIKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reopened TIKA-1387: --------------------------------- I disagree wth some fixes, because they just workaround the forbidden-checks by still using system defaults. > Add forbidden-apis checker to TIKA build > ---------------------------------------- > > Key: TIKA-1387 > URL: https://issues.apache.org/jira/browse/TIKA-1387 > Project: Tika > Issue Type: Improvement > Components: general > Reporter: Uwe Schindler > Assignee: Tyler Palsulich > Fix For: 1.7 > > Attachments: TIKA-1387.palsulich.080614.patch, TIKA-1387.patch, TIKA-1387.patch, TIKA-1387.patch > > > Lucene and many other projects already use the forbidden-apis checker to prevent use of some broken classes/signatures from the JDK. These are especially thing using default character sets or default locales. The forbidden-api checker can also be used to explcitely disallow specific methods, if they have security issues (e.g., creating XML parsers without disabling external entity support). > The attached patch adds the forbidden-api checker to the tika-parent pom file with default configuration. > Running it fails with many errors in TIKA core already: > {noformat} > [INFO] --- forbiddenapis:1.6.1:check (default) @ tika-core --- > [INFO] Scanning for classes to check... > [INFO] Reading bundled API signatures: jdk-unsafe > [INFO] Reading bundled API signatures: jdk-deprecated > [INFO] Loading classes to check... > [INFO] Scanning for API signatures and dependencies... > [ERROR] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset] > [ERROR] in org.apache.tika.language.LanguageProfilerBuilder (LanguageProfilerBuilder.java:407) > [ERROR] Forbidden method invocation: java.lang.String#toUpperCase() [Uses default locale] > [ERROR] in org.apache.tika.io.FilenameUtils (FilenameUtils.java:68) > [ERROR] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset] > [ERROR] in org.apache.tika.io.IOUtils (IOUtils.java:257) > [ERROR] Forbidden method invocation: java.lang.String#(byte[]) [Uses default charset] > [ERROR] in org.apache.tika.io.IOUtils (IOUtils.java:395) > [ERROR] Forbidden method invocation: java.lang.String#(byte[]) [Uses default charset] > [ERROR] in org.apache.tika.io.IOUtils (IOUtils.java:416) > [ERROR] Forbidden method invocation: java.io.InputStreamReader#(java.io.InputStream) [Uses default charset] > [ERROR] in org.apache.tika.io.IOUtils (IOUtils.java:438) > [ERROR] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset] > [ERROR] in org.apache.tika.io.IOUtils (IOUtils.java:532) > [ERROR] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset] > [ERROR] in org.apache.tika.io.IOUtils (IOUtils.java:550) > [ERROR] Forbidden method invocation: java.lang.String#(byte[]) [Uses default charset] > [ERROR] in org.apache.tika.io.IOUtils (IOUtils.java:588) > [ERROR] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset] > [ERROR] in org.apache.tika.io.IOUtils (IOUtils.java:656) > [ERROR] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset] > [ERROR] in org.apache.tika.io.IOUtils (IOUtils.java:782) > [ERROR] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset] > [ERROR] in org.apache.tika.io.IOUtils (IOUtils.java:851) > [ERROR] Forbidden method invocation: java.io.InputStreamReader#(java.io.InputStream) [Uses default charset] > [ERROR] in org.apache.tika.io.IOUtils (IOUtils.java:957) > [ERROR] Forbidden method invocation: java.io.OutputStreamWriter#(java.io.OutputStream) [Uses default charset] > [ERROR] in org.apache.tika.io.IOUtils (IOUtils.java:1064) > [ERROR] Forbidden method invocation: java.io.OutputStreamWriter#(java.io.OutputStream) [Uses default charset] > [ERROR] in org.apache.tika.sax.WriteOutContentHandler (WriteOutContentHandler.java:93) > [ERROR] Forbidden method invocation: java.io.InputStreamReader#(java.io.InputStream) [Uses default charset] > [ERROR] in org.apache.tika.parser.external.ExternalParser (ExternalParser.java:234) > [ERROR] Forbidden method invocation: java.io.InputStreamReader#(java.io.InputStream) [Uses default charset] > [ERROR] in org.apache.tika.parser.external.ExternalParser$3 (ExternalParser.java:294) > [ERROR] Forbidden method invocation: java.util.Calendar#getInstance(java.util.Locale) [Uses default locale or time zone] > [ERROR] in org.apache.tika.utils.DateUtils (DateUtils.java:83) > [ERROR] Forbidden method invocation: java.lang.String#format(java.lang.String,java.lang.Object[]) [Uses default locale] > [ERROR] in org.apache.tika.utils.DateUtils (DateUtils.java:91) > [ERROR] Forbidden method invocation: java.lang.String#toLowerCase() [Uses default locale] > [ERROR] in org.apache.tika.detect.MagicDetector (MagicDetector.java:98) > [ERROR] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset] > [ERROR] in org.apache.tika.detect.MagicDetector (MagicDetector.java:100) > [ERROR] Forbidden method invocation: java.lang.String#(byte[]) [Uses default charset] > [ERROR] in org.apache.tika.detect.MagicDetector (MagicDetector.java:396) > [ERROR] Forbidden method invocation: java.io.OutputStreamWriter#(java.io.OutputStream) [Uses default charset] > [ERROR] in org.apache.tika.sax.ToTextContentHandler (ToTextContentHandler.java:60) > [ERROR] Scanned 225 (and 356 related) class file(s) for forbidden API invocations (in 0.42s), 23 error(s). > {noformat} > We should fix those problems. -- This message was sent by Atlassian JIRA (v6.2#6252)