tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TIKA-1558) Create a Parser Blacklist
Date Tue, 31 Mar 2015 17:11:53 GMT

    [ https://issues.apache.org/jira/browse/TIKA-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388855#comment-14388855

ASF GitHub Bot commented on TIKA-1558:

GitHub user tpalsulich opened a pull request:


    Refactor TIKA-1558. Remove service loading blacklist

    * Remove all direct service loading logic regarding a blacklist.
    * Small changes to CompositeParser logic to make sure subclasses of excluded Parsers are
also excluded.
    * Added new testing in the tika-core module to test regular and subclass exclusion.
    @Gagravarr, can you look this over?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tpalsulich/tika TIKA-1558

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #39
commit 7e38e3cdef3f5ae11d45863c67c6216561802a32
Author: Tyler Palsulich <tpalsulich@gmail.com>
Date:   2015-03-31T17:05:19Z

    Refactor TIKA-1558. Remove service loading blacklist and ensure subclasses are also excluded.


> Create a Parser Blacklist
> -------------------------
>                 Key: TIKA-1558
>                 URL: https://issues.apache.org/jira/browse/TIKA-1558
>             Project: Tika
>          Issue Type: New Feature
>            Reporter: Tyler Palsulich
>            Assignee: Tyler Palsulich
>             Fix For: 1.8
> As talked about in TIKA-1555 and TIKA-1557, it would be nice to be able to disable Parsers
without pulling their dependencies out. In some cases (e.g. disable all ExternalParsers),
there may not be an easy way to exclude the dependencies via Maven.
> So, an initial design would be to include another file like {{META-INF/services/org.apache.tika.parser.Parser.blacklist}}.
We create a new method {{ServiceLoader#loadServiceProviderBlacklist}}. Then, in {{ServiceLoader#loadServiceProviders}},
we remove all elements of the list that are assignable to an element in {{ServiceLoader#loadServiceProviderBlacklist}}.

This message was sent by Atlassian JIRA

View raw message