tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Paulin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TIKA-1700) tika-config.xml does not provide a way to set ServiceLoader to dynamic
Date Thu, 30 Jul 2015 22:23:04 GMT

    [ https://issues.apache.org/jira/browse/TIKA-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648404#comment-14648404

Bob Paulin commented on TIKA-1700:

[~gagravarr] Do you have a specific thread from the mailing list you can link in here.  I
was having some trouble finding the pattern you're referring to.  Does the attached Patch
fall inline to the pattern you previously discussed?

> tika-config.xml does not provide a way to set ServiceLoader to dynamic
> ----------------------------------------------------------------------
>                 Key: TIKA-1700
>                 URL: https://issues.apache.org/jira/browse/TIKA-1700
>             Project: Tika
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.7, 1.8, 1.9, 1.10
>         Environment: OSGi
>            Reporter: Bob Paulin
>         Attachments: TIKA-1700.patch
> Currently if you create a TikaConfig from a file (ex tika-config.xml).  There is no way
to specify that you want to use a ServiceLoader with dynamic set.  Prior to tika 1.7 this
was not an issue since the during the tika-config.xml parse Tika would instantiate parsers
using the default constructor which in turn would instantiate a new ServiceLoader.  The default
ServiceLoader constructor sets dynamic to true which allows dynamic loading of parsers.  
> Changes to TikaConfig now cause the tika-config.xml parse to call a constructor which
passes the ServiceLoader to be passed as a parameter.  This ServiceLoader is always constructed
with a Classloader which will cause dynamic to always be set to false.  This breaks Tika in
OSGi environments which depend on dynamic being set to true (for example Apache Sling). 
> I'm proposing adding an xml attribute to the parser element to instantiate the parser
with dynamic set to true.  This allows users of tika-config.xml to determine how they want
parsers loaded. 

This message was sent by Atlassian JIRA

View raw message