[ https://issues.apache.org/jira/browse/TIKA-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219299#comment-15219299
]
Bob Paulin commented on TIKA-1706:
----------------------------------
Performed removal of duplicated tika.io classes and replaced with commons-io 2.4 in the Tika
2.0 branch.
> Bring back commons-io to tika-core
> ----------------------------------
>
> Key: TIKA-1706
> URL: https://issues.apache.org/jira/browse/TIKA-1706
> Project: Tika
> Issue Type: Improvement
> Components: core
> Reporter: Yaniv Kunda
> Priority: Minor
> Fix For: 1.13
>
> Attachments: TIKA-1706-1.patch, TIKA-1706-2.patch
>
>
> TIKA-249 inlined select commons-io classes in order to simplify the dependency tree and
save some space.
> I believe these arguments are weaker nowadays due to the following concerns:
> - Most of the non-core modules already use commons-io, and since tika-core is usually
not used by itself, commons-io is already included with it
> - Since some modules use both tika-core and commons-io, it's not clear which code should
be used
> - Having the inlined classes causes more maintenance and/or technology debt (which in
turn causes more maintenance)
> - Newer commons-io code utilizes newer platform code, e.g. using Charset objects instead
of encoding names, being able to use StringBuilder instead of StringBuffer, and so on.
> I'll be happy to provide a patch to replace usages of the inlined classes with commons-io
classes if this is accepted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|