tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TIKA-1706) Bring back commons-io to tika-core
Date Thu, 31 Mar 2016 04:24:25 GMT

    [ https://issues.apache.org/jira/browse/TIKA-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219308#comment-15219308
] 

Hudson commented on TIKA-1706:
------------------------------

FAILURE: Integrated in tika-2.x #65 (See [https://builds.apache.org/job/tika-2.x/65/])
TIKA-1915 and TIKA-1706 - Remove POI. Replace with commons-io+tika-core (bob: rev 05f4af3002f1f376095f6b4810d505ea50d08b3c)
* tika-parser-modules/tika-parser-cad-module/pom.xml
* tika-core/src/main/java/org/apache/tika/io/IOExceptionWithCause.java
* tika-parser-modules/tika-parser-multimedia-module/src/main/java/org/apache/tika/parser/image/PSDParser.java
* tika-core/src/main/java/org/apache/tika/io/ClosedInputStream.java
* tika-core/pom.xml
* tika-parser-modules/tika-parser-cad-module/src/main/java/org/apache/tika/parser/prt/PRTParser.java
* tika-langdetect/src/test/java/org/apache/tika/langdetect/OptimaizeLangDetectorTest.java
* tika-core/src/main/java/org/apache/tika/io/TaggedIOException.java
* tika-core/src/main/java/org/apache/tika/io/IOUtils.java
* tika-core/src/test/java/org/apache/tika/TypeDetectionBenchmark.java
* tika-core/src/main/java/org/apache/tika/parser/NetworkParser.java
* tika-core/src/main/java/org/apache/tika/parser/external/ExternalParser.java
* tika-core/src/main/java/org/apache/tika/extractor/ParsingEmbeddedDocumentExtractor.java
* tika-core/src/main/java/org/apache/tika/io/StringUtil.java
* tika-parser-modules/tika-parser-multimedia-module/src/main/java/org/apache/tika/parser/image/BPGParser.java
* tika-core/src/main/java/org/apache/tika/Tika.java
* tika-core/src/test/java/org/apache/tika/sax/SecureContentHandlerTest.java
* tika-parser-modules/tika-parser-multimedia-module/pom.xml
* tika-parser-modules/tika-parser-advanced-module/src/main/java/org/apache/tika/parser/ner/opennlp/OpenNLPNameFinder.java
* tika-parser-modules/tika-parser-cad-module/src/main/java/org/apache/tika/parser/dwg/DWGParser.java
* tika-app/src/test/java/org/apache/tika/parser/mock/MockParserTest.java
* tika-parser-bundles/tika-parser-cad-bundle/pom.xml
* tika-core/src/main/java/org/apache/tika/detect/XmlRootExtractor.java
* tika-parser-modules/tika-parser-advanced-module/src/main/java/org/apache/tika/parser/ner/corenlp/CoreNLPNERecogniser.java
* tika-core/src/test/java/org/apache/tika/TikaTest.java
* tika-core/src/test/java/org/apache/tika/io/TikaInputStreamTest.java
* tika-parser-bundles/tika-parser-multimedia-bundle/pom.xml
* tika-parser-modules/tika-parser-multimedia-module/src/main/java/org/apache/tika/parser/image/ImageMetadataExtractor.java
* tika-core/src/main/java/org/apache/tika/io/NullInputStream.java
* tika-core/src/main/java/org/apache/tika/embedder/ExternalEmbedder.java
* tika-langdetect/src/test/java/org/apache/tika/langdetect/LanguageDetectorTest.java
* tika-core/src/main/java/org/apache/tika/io/CloseShieldInputStream.java
* tika-core/src/main/java/org/apache/tika/io/NullOutputStream.java
* tika-core/src/main/java/org/apache/tika/sax/OfflineContentHandler.java
* tika-core/src/main/java/org/apache/tika/fork/ForkClient.java
* tika-core/src/main/java/org/apache/tika/io/CountingInputStream.java


> Bring back commons-io to tika-core
> ----------------------------------
>
>                 Key: TIKA-1706
>                 URL: https://issues.apache.org/jira/browse/TIKA-1706
>             Project: Tika
>          Issue Type: Improvement
>          Components: core
>            Reporter: Yaniv Kunda
>            Priority: Minor
>             Fix For: 1.13
>
>         Attachments: TIKA-1706-1.patch, TIKA-1706-2.patch
>
>
> TIKA-249 inlined select commons-io classes in order to simplify the dependency tree and
save some space.
> I believe these arguments are weaker nowadays due to the following concerns:
> - Most of the non-core modules already use commons-io, and since tika-core is usually
not used by itself, commons-io is already included with it
> - Since some modules use both tika-core and commons-io, it's not clear which code should
be used
> - Having the inlined classes causes more maintenance and/or technology debt (which in
turn causes more maintenance)
> - Newer commons-io code utilizes newer platform code, e.g. using Charset objects instead
of encoding names, being able to use StringBuilder instead of StringBuffer, and so on.
> I'll be happy to provide a patch to replace usages of the inlined classes with commons-io
classes if this is accepted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message