tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TIKA-1929) Need to close resources on exception in sqlite parser
Date Mon, 04 Apr 2016 18:41:25 GMT

    [ https://issues.apache.org/jira/browse/TIKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224773#comment-15224773

Hudson commented on TIKA-1929:

FAILURE: Integrated in tika-trunk-jdk1.7 #941 (See [https://builds.apache.org/job/tika-trunk-jdk1.7/941/])
TIKA-1929 -- ensure deletion of temp file no matter which type of (tallison: rev 6a3aa1a713a990539e58f68b4c902f9f93d5372e)
* tika-parsers/src/main/java/org/apache/tika/parser/jdbc/SQLite3DBParser.java
* tika-parsers/src/main/java/org/apache/tika/parser/jdbc/AbstractDBParser.java
* tika-parsers/src/main/java/org/apache/tika/parser/jdbc/SQLite3Parser.java
* tika-parsers/src/test/java/org/apache/tika/parser/jdbc/SQLite3ParserTest.java
TIKA-1929 insignificant cleanup (tallison: rev 1c854185af6ad5668127b69a459fff2f45188774)
* tika-parsers/src/main/java/org/apache/tika/parser/jdbc/SQLite3DBParser.java

> Need to close resources on exception in sqlite parser
> -----------------------------------------------------
>                 Key: TIKA-1929
>                 URL: https://issues.apache.org/jira/browse/TIKA-1929
>             Project: Tika
>          Issue Type: Bug
>            Reporter: Tim Allison
>            Priority: Minor
> If there's an exception during parsing of a SQLite file, we aren't guaranteeing that
the temp file is deleted.
> If a TikaInputStream is used, we assume the calling code will close the stream and thereby
delete the temp file.  However, if another type of InputStream is used, we copy that to a
temp file, and we need to ensure that we delete that temp file if there's an exception during
the parse.
> While we're at it, we should also clean up test code to close streams correctly.
> Unrelated to this issue... I noticed that xerial's SQLite code is still leaving behind
a copy of the native dll in the temp folder on Windows the first time the SQLite parser is
called.  See https://github.com/xerial/sqlite-jdbc/issues/80.

This message was sent by Atlassian JIRA

View raw message