tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TIKA-2400) Standardizing current Object Recognition REST parsers
Date Sun, 24 Sep 2017 23:20:02 GMT

    [ https://issues.apache.org/jira/browse/TIKA-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178400#comment-16178400
] 

ASF GitHub Bot commented on TIKA-2400:
--------------------------------------

thammegowda commented on a change in pull request #208: Fix for TIKA-2400 Standardizing current
Object Recognition REST parsers
URL: https://github.com/apache/tika/pull/208#discussion_r140670568
 
 

 ##########
 File path: tika-parsers/src/main/java/org/apache/tika/parser/recognition/tf/TensorflowRESTRecogniser.java
 ##########
 @@ -73,19 +74,27 @@
     /**
      * Maximum buffer size for image
      */
-    private static final String LABEL_LANG = "en";
+    protected static final String LABEL_LANG = "en";
 
 Review comment:
   Also in the future, wherever you want to use language code, please use ISO 639-2, which
is `eng` for English.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Standardizing current Object Recognition REST parsers
> -----------------------------------------------------
>
>                 Key: TIKA-2400
>                 URL: https://issues.apache.org/jira/browse/TIKA-2400
>             Project: Tika
>          Issue Type: Sub-task
>          Components: parser
>            Reporter: Thejan Wijesinghe
>            Priority: Minor
>             Fix For: 1.17
>
>
> # This involves adding apiBaseUris and refactoring current Object Recognition REST parsers,
> # Refactoring dockerfiles related to those parsers.
> #  Moving the logic related to checking minimum confidence into servers



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message