tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TIKA-2731) Unecessary call to System.getProperties() in XMLReaderUtils
Date Fri, 21 Sep 2018 22:12:00 GMT

    [ https://issues.apache.org/jira/browse/TIKA-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624247#comment-16624247
] 

Hudson commented on TIKA-2731:
------------------------------

SUCCESS: Integrated in Jenkins build tika-branch-1x #95 (See [https://builds.apache.org/job/tika-branch-1x/95/])
TIKA-2731 via jkakvas.  This closes 250. (tallison: [https://github.com/apache/tika/commit/f6c38efc9eefa1b872bd64ad2f25e363919121da])
* (edit) tika-core/src/main/java/org/apache/tika/utils/XMLReaderUtils.java
TIKA-2731 via jkakavas.  This closes 250. (tallison: [https://github.com/apache/tika/commit/c25671c3a1542f3a714ad687afe30dfc8759c450])
* (edit) tika-core/src/main/java/org/apache/tika/utils/XMLReaderUtils.java


> Unecessary call to System.getProperties() in XMLReaderUtils
> -----------------------------------------------------------
>
>                 Key: TIKA-2731
>                 URL: https://issues.apache.org/jira/browse/TIKA-2731
>             Project: Tika
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.19
>            Reporter: Ioannis Kakavas
>            Assignee: Tim Allison
>            Priority: Major
>             Fix For: 1.20
>
>
> As part of the changes introduced in [1.19 |https://github.com/apache/tika/commit/4e67928412ad56333d400f3728ecdb59d07d9d63]
determineMaxEntityExpansions needs to read the jdk.xml.entityExpansionLimit System Property
in order to overwrite the default value of 20, if it is set. 
> This is however by reading all System Properties with System.getProperties() and attempting
to find the relevant key in the properties Object. The issue with this approach is that getProperties()
requires 
> {noformat}java.util.PropertyPermission "*", "read,write"{noformat}
> which is overly permissive.
> A more sane approach, following the least privilege design principal would be to use
System.getProperty() for the specific property that only requires 
> {noformat}java.util.PropertyPermission "jdk.xml.entityExpansionLimit", "read"{noformat}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message