tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TIKA-2873) Some password protected xlsx file no longer opens with password
Date Tue, 14 May 2019 21:17:00 GMT

    [ https://issues.apache.org/jira/browse/TIKA-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839802#comment-16839802
] 

Hudson commented on TIKA-2873:
------------------------------

FAILURE: Integrated in Jenkins build tika-2.x-windows #418 (See [https://builds.apache.org/job/tika-2.x-windows/418/])
TIKA-2873 -- workaround for newly re-discovered bug in POI's (tallison: rev 0d9dacdc6ca153572a7570f7934ec82f1c2ea92e)
* (edit) tika-parsers/src/main/java/org/apache/tika/parser/microsoft/OfficeParser.java
* (edit) tika-parsers/src/test/java/org/apache/tika/parser/microsoft/ooxml/OOXMLParserTest.java
* (add) tika-parsers/src/test/resources/test-documents/testEXCEL_protected_passtika_2.xlsx


> Some password protected xlsx file no longer opens with password
> ---------------------------------------------------------------
>
>                 Key: TIKA-2873
>                 URL: https://issues.apache.org/jira/browse/TIKA-2873
>             Project: Tika
>          Issue Type: Task
>            Reporter: Tim Allison
>            Priority: Major
>
>   A password protected .xlsx file can no longer be read because there's a bug in POI's
ChunkedCipherInputStream:
> {noformat}
> @Override
> public int read() throws IOException {
>     byte[] b = \{ 0 };
>     // FIXME: compare against -1 or 1? (bug 59893)
>     return (read(b) == 1) ? -1 : b[0];
> }
>  {noformat}
>   Reading with a byte[] works fine, but read() individual bytes returns -1 if the stream
had something in it.  Because of some recent changes...we now wrap the ChunkedCipherInputStream
in a RereadableInputStream...whereas we didn't before...this wrapping is now calling {{read()}}
at some point where the stream used to only be {{read(byte[])}}.  We can fix this by wrapping
the ChunkedCipherInputStream in a TikaInputStream...
> I think this is significant enough to do a respin of 1.21-rc1...what do you think?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message