tika-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Allison <talli...@apache.org>
Subject Re: TabularFormatsTest test fails in Germany
Date Sat, 05 Oct 2019 17:27:59 GMT
+1

Thank you!

On Sat, Oct 5, 2019 at 1:15 PM Tilman Hausherr <THausherr@t-online.de>
wrote:

> Am 05.10.2019 um 17:46 schrieb Tim Allison:
> > As for the repo, I work directly w GitHub, but wip should work.
> >
> > I don’t think we’ve codified line length, but please do as you see fit.
>
> I decided to refactor the code and it is much better now and the code
> line length question doesn't exist anymore, haha.
>
> Tilman
>
>
> >
> > I’ve started using Maven checkstyle on another project...I shudder to
> think
> > of the amount of time it would take to get our code into shape...if only
> I
> > had a few long plane rides in my future... :D
> >
> > On Sat, Oct 5, 2019 at 10:30 AM Tilman Hausherr <THausherr@t-online.de>
> > wrote:
> >
> >> Am 04.10.2019 um 17:32 schrieb Tim Allison:
> >>> Would it work to set the expected String to something generated with
> the
> >>> root locale?
> >> I managed to create such code: we need both the US and the local month
> >> names. I get these with
> >>
> >>       new DateFormatSymbols(Locale.getDefault()).getShortMonths()
> >>
> >> Because testCSV() always brings the english names, the others the local
> >> names.
> >>
> >> I understand that the code conventions mean that braces are K&R style.
> >>
> >> Is there a max line length in this project? I ask this because it is
> >> very long.
> >>
> >> Is there also a branch or is there just the master to commit to? Should
> >> I just commit to the server (
> >> https://git-wip-us.apache.org/repos/asf/tika ) or is this done in a
> >> different way? Any common pitfalls?
> >>
> >> Tilman
> >>
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message