tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ceefour <...@git.apache.org>
Subject [GitHub] incubator-tinkerpop pull request: slf4j-log4j12 / log4j is only re...
Date Mon, 04 Apr 2016 11:27:54 GMT
Github user ceefour commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/233#issuecomment-205253990
  
    @spmallette Sorry i forgot to actually make the change.
    
    The assembly files were incorrect from the start since it only includes "compile" dependencies
meaning "runtime" dependencies (which didn't exist before) were left out. I made the slf4j
impl/log4j runtime or test dependencies since they're not required to compile (and users of
the library can use any slf4j impl, not just log4j, i.e. me and Spring Boot )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message