tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From spmallette <...@git.apache.org>
Subject [GitHub] incubator-tinkerpop pull request: Fix TINKERPOP-1252
Date Thu, 07 Apr 2016 12:36:39 GMT
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/288#issuecomment-206863431
  
    > I wouldn't have any problem with cascaded finally blocks to make sure everything
is getting called; if that seems better to you, I can update the pull request to do that.
    
    It's not pretty, but I think you should. In that way, we can be sure everything gets called
and if neo4j ever changes that code to provide a way to fail, we'll be covered.
    
    > I wasn't sure if I should create two pull requests: this one and one for the tp31
branch
    
    Please just re-target this PR to tp31 and we'll handling merging it appropriately. Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message