tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-1151) slf4j-log4j12 / log4j is only required for testing
Date Mon, 04 Apr 2016 11:28:25 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223966#comment-15223966
] 

ASF GitHub Bot commented on TINKERPOP-1151:
-------------------------------------------

Github user ceefour commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/233#issuecomment-205253990
  
    @spmallette Sorry i forgot to actually make the change.
    
    The assembly files were incorrect from the start since it only includes "compile" dependencies
meaning "runtime" dependencies (which didn't exist before) were left out. I made the slf4j
impl/log4j runtime or test dependencies since they're not required to compile (and users of
the library can use any slf4j impl, not just log4j, i.e. me and Spring Boot )


> slf4j-log4j12 / log4j is only required for testing
> --------------------------------------------------
>
>                 Key: TINKERPOP-1151
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1151
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: build-release
>    Affects Versions: 3.1.0-incubating
>            Reporter: Hendy Irawan
>            Priority: Trivial
>
> Pull request: https://github.com/apache/incubator-tinkerpop/pull/229



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message