tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From newkek <...@git.apache.org>
Subject [GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.
Date Fri, 08 Jul 2016 12:53:16 GMT
Github user newkek commented on the issue:

    https://github.com/apache/tinkerpop/pull/351
  
    @robertdale the format you suggest would lead to the same inconsistencies as in GraphSON
1.0. Since the type is at the same level than the data itself, whether the container is an
Array or an Object, the type format would not be the same. I just pushed a change in the format
that is the one @PommeVerte suggested, which gives a consistent format, without the concern
of unordered Lists (for reference the new format is `{"@type" : "typeName", "@value" : value}`.
    
    > please correct me if I'm wrong, but it doesn't look like the code does any dynamic
serializing.
    
    The `TypeIdResolver` which is the object that the serializers will call to get a TypeID
from a java `Object` is dynamic in a way, in the sense that it returns `o.getClass().getSimpleName()`.
So there is no `object` -> typeID index reference. However for the Deser, as explained
in the description, Java by default doesn't offer a way to get a Class by its simple name,
so the `TypeIdResolver` needs to keep a reference index of typeID(which is a class's simple
name) -> Java `Class`. Don't know if that answers your question..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message