tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FlorianHockmann <...@git.apache.org>
Subject [GitHub] tinkerpop issue #802: Add docker images for console and server TINKERPOP-189...
Date Mon, 04 Jun 2018 14:55:11 GMT
Github user FlorianHockmann commented on the issue:

    https://github.com/apache/tinkerpop/pull/802
  
    > I only see the 3.2 tag - where the 3.2.10-rc1? shouldn't that be up there too?
    
    Yes and the `3.2` tag should only exist for non-SNAPSHOT versions, but I guess that we
didn't think about release candidate versions when we added that check:
    ```xml
    <name>only.when.is.snapshot.used</name>
    <value>${project.version}</value>
    <regex>.*-SNAPSHOT</regex>
    ```
    https://github.com/apache/tinkerpop/blob/tp32/pom.xml#L283
    
    Regarding the full version (3.2.10-rc1), my assumption was that this is already handled
by:
    ```xml
    <configuration>
        <tag>${project.version}</tag>
    ```
    https://github.com/apache/tinkerpop/blob/tp32/gremlin-console/pom.xml#L369
    and I'm pretty sure that it worked like that in my tests.
    
    But maybe we can add the tagging as a separate `execution` just for this tag? 


---

Mime
View raw message