tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jorgebay <...@git.apache.org>
Subject [GitHub] tinkerpop pull request #867: TINKERPOP-1836 Add Gremlin.Net.Template project
Date Tue, 05 Jun 2018 13:12:01 GMT
Github user jorgebay commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/867#discussion_r193065380
  
    --- Diff: gremlin-dotnet/src/pom.xml ---
    @@ -89,6 +93,54 @@ limitations under the License.
                                 <nugetAddEnabled>false</nugetAddEnabled>
                             </configuration>
                         </plugin>
    +                    <plugin>
    +                        <groupId>org.apache.maven.plugins</groupId>
    +                        <artifactId>maven-antrun-plugin</artifactId>
    +                        <executions>
    +                            <execution>
    +                                <id>pack-dotnet-template</id>
    +                                <phase>package</phase>
    --- End diff --
    
    Would it be possible to move the execution to the `deploy` phase? that way on `install`
or prior phases, the build wouldn't be affected.
    
    Also, it won't require mono on TravisCI or docker-based builds.


---

Mime
View raw message