tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-1518) Cache Graph.Features
Date Fri, 08 Jun 2018 12:05:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505942#comment-16505942

ASF GitHub Bot commented on TINKERPOP-1518:

GitHub user spmallette opened a pull request:


    TINKERPOP-1518 Cache Graph.Features for tests

    For graphs that have an expensive startup time but a static set of `Graph.Features` the
new `GraphProvider.getStaticFeatures()` method should help speed their test times as it will
prevent creation of a new `Graph` instance for the test if the graph does not support the
requisite features. For testing purposes, this capability was implemented for Neo4j, but it
didn't do much to speed the execution time of the test suite - saved a couple minutes or so.
It's generally pretty cheap to create Neo4j instances themselves, so I guess that is expected.
    (just issued the PR, not quite ready for VOTE yet)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1518

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #873
commit aec170982aa03d1a07248721cb045ba95e11188b
Author: Stephen Mallette <spmva@...>
Date:   2018-06-08T00:15:53Z

    TINKERPOP-1518 GraphProvider allows for caching of graph features

commit 221fda584c6baf7c65eb4e6eebf72bb0ba251de4
Author: Stephen Mallette <spmva@...>
Date:   2018-06-08T11:45:29Z

    TINKERPOP-1518 Minor refactoring - extracted requirement check function


> Cache Graph.Features
> --------------------
>                 Key: TINKERPOP-1518
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1518
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.2.2
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Major
>             Fix For: 3.4.0
> Determine if there's a way to cache graph features to avoid having to load a {{Graph}}
instance for a test. That could save some test cycles for graphs that dont' support a test.

This message was sent by Atlassian JIRA

View raw message