tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stephen mallette (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (TINKERPOP-1809) Process tests shouldn't modify toy data
Date Wed, 06 Jun 2018 18:43:00 GMT

     [ https://issues.apache.org/jira/browse/TINKERPOP-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

stephen mallette closed TINKERPOP-1809.
    Resolution: Won't Do

After some reflection, I don't think there is a need to do this. Providers can detect if a
test is mutating data on a toy graph by simply checking features and we already have a working
model for dealing with GLV tests.

> Process tests shouldn't modify toy data
> ---------------------------------------
>                 Key: TINKERPOP-1809
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1809
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.2.6
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
> While working on TINKERPOP-1784 i noticed that process test suites modify the data in
toy graphs. That works in the java suite because we can easily and quickly reload toy graph
data between tests (though it can be expensive for some graphs). For GLVs it's slow and non-trivial
to do this reload. To be consistent in the tests (especially while we have both test suites
in place) we should make the java suite behave like the GLV and not mutate the static toy
graphs so that they don't need to be cleared between runs. This might be helpful to java test
suite users as well as it could given them a chance to speed up their builds.

This message was sent by Atlassian JIRA

View raw message