tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stephen mallette (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (TINKERPOP-1965) Make MessageCombiner a bit more flexible
Date Tue, 05 Jun 2018 20:03:00 GMT

     [ https://issues.apache.org/jira/browse/TINKERPOP-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

stephen mallette closed TINKERPOP-1965.
       Resolution: Invalid
    Fix Version/s:     (was: 3.4.0)

I think I misunderstood the nature of {{MessageCombiner}} when I wrote this. Closing.

> Make MessageCombiner a bit more flexible
> ----------------------------------------
>                 Key: TINKERPOP-1965
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1965
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.3.3
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>              Labels: breaking
> Currently {{MessageCombiner}} takes two messages and forces them to one, but in some
cases you might want to have logic that makes the choice as to whether or not to combine or
keep the messages separate. Perhaps the signature should be:
> {code}
> public List<M> combine(final M messageA, final M messageB);
> {code}
> or something similar that would allow return of one object or two. Not sure if it is
worth deprecating the old code - perhaps we just make it a straight breaking change on 3.4.0.

This message was sent by Atlassian JIRA

View raw message