tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-1987) Bump to Netty 4.1.x
Date Fri, 29 Jun 2018 20:16:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528180#comment-16528180
] 

ASF GitHub Bot commented on TINKERPOP-1987:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/886

    TINKERPOP-1987 Bump to Spark 2.3.1 and Netty 4.1.25.Final

    https://issues.apache.org/jira/browse/TINKERPOP-1987
    
    These really needed to be bumped together because going to netty 4.1.x doesn't work nicely
with Spark 2.2.x - Spark only upgraded to that version on 2.3.x. 
    
    That odd change to `gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs`
is incidental - that modification is already on master and rebase doesn't seem to to want
to get rid of it. Hopefully no one is too turned off by that little stain in change history
- doesn't seem like a huge problem.
    
    All tests pass with `docker/build.sh -t -n -i`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1987

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/886.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #886
    
----
commit 07ca64e9d462a0ea496d3924953532f8b794346f
Author: Stephen Mallette <spmva@...>
Date:   2018-06-27T12:23:58Z

    Bump to Spark 2.3.1 and Netty 4.1.25.Final
    
    These really needed to be bumped together because going to netty 4.1.x doesn't work nicely
with Spark 2.2.x - Spark only upgraded on 2.3.x.

----


> Bump to Netty 4.1.x
> -------------------
>
>                 Key: TINKERPOP-1987
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1987
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Robert Dale
>            Assignee: stephen mallette
>            Priority: Major
>
> Netty 4.0.x is EOL:
> https://twitter.com/normanmaurer/status/960798363695435778



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message