tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From spmallette <...@git.apache.org>
Subject [GitHub] tinkerpop issue #923: TINKERPOP-2028: Register GremlinServerModule to GraphS...
Date Tue, 04 Sep 2018 17:19:15 GMT
Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/923
  
    This seems to build now along with gremlin server integration tests. Any reason to not
go to `tp33`? if not, please squash and retarget and i can go ahead an move to merge.
    
    Please also take a look at adding `final` to variables where needed.  A CHANGELOG entry
might be good too. 
    
    Thanks for this.
    
    VOTE +1


---

Mime
View raw message