tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ashwinisingh01 <...@git.apache.org>
Subject [GitHub] tinkerpop issue #915: Tinkerpop 1913-Followup
Date Wed, 05 Sep 2018 22:10:22 GMT
Github user ashwinisingh01 commented on the issue:

    https://github.com/apache/tinkerpop/pull/915
  
    Thanks Patrik. I will get back to before EOW and wrap up on open comments.
    
    
    
    Get Outlook for Android<https://aka.ms/ghei36>
    
    
    
    From: Patrik Husfloen
    Sent: Wednesday, September 5, 2:50 PM
    Subject: Re: [apache/tinkerpop] Tinkerpop 1913-Followup (#915)
    To: apache/tinkerpop
    Cc: Ashwini Singh, Mention
    
    
    I wanted to see some progress on this, so I took a stab at rebasing and exposing the attribute
collection on the ResponseException as well. You can find it here: redoz@<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fredoz%2Ftinkerpop%2Fcommit%2Fe48c0af80873498e50a5383bdcf626e078018db5&data=02%7C01%7Cashwsing%40microsoft.com%7C148296e60c144f91ddab08d613799ce1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636717810377750545&sdata=uCO9aSoC6W%2F2foZNHt%2BALRKSGZwCFh0X0QSZ3pCACx4%3D&reserved=0>e48c0af<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fredoz%2Ftinkerpop%2Fcommit%2Fe48c0af80873498e50a5383bdcf626e078018db5&data=02%7C01%7Cashwsing%40microsoft.com%7C148296e60c144f91ddab08d613799ce1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636717810377750545&sdata=uCO9aSoC6W%2F2foZNHt%2BALRKSGZwCFh0X0QSZ3pCACx4%3D&reserved=0>
    Is there a good reason for not exposing the StatusCode on the ResponseException as well?
I'm not familiar enough with the protocol to say whether that's an internal detail or something
the consumer should be able to react to.
    —
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ftinkerpop%2Fpull%2F915%23issuecomment-418893147&data=02%7C01%7Cashwsing%40microsoft.com%7C148296e60c144f91ddab08d613799ce1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636717810377750545&sdata=EmJDQNw%2FhFIgQRAUAntJzXWHqRl1tsRTawsIEYr6UDw%3D&reserved=0>,
or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAoVVyr3yRtMF5CEvQ1MTUojjOtrfP7B9ks5uYEcrgaJpZM4V9OiB&data=02%7C01%7Cashwsing%40microsoft.com%7C148296e60c144f91ddab08d613799ce1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636717810377760549&sdata=mWMrv0sfDkMgXqGtNGIpLTEGDlsjVA8Eysk1eE97J%2FQ%3D&reserved=0>.
    
    



---

Mime
View raw message