tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FlorianHockmann <...@git.apache.org>
Subject [GitHub] tinkerpop issue #903: Gremlin.Net: Add ConnectionPool min and max sizes TINK...
Date Fri, 07 Sep 2018 14:32:07 GMT
Github user FlorianHockmann commented on the issue:

    https://github.com/apache/tinkerpop/pull/903
  
    >I think the ultimate solution would be for the pool to balance request between connections,
and without taking them out of the pool each time a request/response is issued.
    
    Why do you want to keep the connections in the pool when a read/write operation is executed
on them? They can't be used at that time anyway and I think that the current design is a lot
easier where a connection is taken from the pool for the request and returned simply by disposing
its `ProxyConnection`.
    I think it should be possible to implement such a request pipelining without changing
the connection pool completely. The connections would only be returned faster. Balancing requests
between connections should also not be necessary as the FIFO nature of the pool should already
provide that without any changes.
    
    Another aspect we should consider here is that this PR includes breaking changes as it
adds a limit to the number of connections that can be used. That is why I would really like
this to land in 3.4.0. TINKERPOP-1775 on the other hand can be implemented any time. So, there
is no rush to implement it right now and I'm not sure whether I will have the time to also
implement that in time for 3.4.0 as I will be OOO for ~2 weeks starting Wednesday and the
3.4.0 release date shouldn't be that far away.
    Long story short, I don't think that this PR should be blocked by TINKERPOP-1775 if that
means that this PR will have to wait for TinkerPop 3.5.0 or even 4.0.0. (If you - or someone
else - find the time to tackle TINKERPOP-1775, then that's of course a different matter.)


---

Mime
View raw message