tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From redoz <...@git.apache.org>
Subject [GitHub] tinkerpop issue #915: Tinkerpop 1913-Followup
Date Sat, 08 Sep 2018 12:47:10 GMT
Github user redoz commented on the issue:

    https://github.com/apache/tinkerpop/pull/915
  
    @FlorianHockmann As this change would make `ResponseStatusCode` public, I was wondering
if we wish to keep it an enum or change it to a static class with constants. Tthere's precedent
for this (https://github.com/aspnet/HttpAbstractions/blob/07d115400e4f8c7a66ba239f230805f03a14ee3d/src/Microsoft.AspNetCore.Http.Abstractions/StatusCodes.cs)
but I believe the rationale is that the HTTP statuscodes are extensible and don't always follow
a standard. I'm not sure if that applies here as well, but given there are several server
implementations maybe it follows that "non-standard" codes could be used? But if this is an
integral part of the protocol specification I think keeping it an enum makes sense.


---

Mime
View raw message