tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From spmallette <...@git.apache.org>
Subject [GitHub] tinkerpop pull request #922: TINKERPOP-1959: Gremlin Javascript ability to s...
Date Thu, 13 Sep 2018 19:12:41 GMT
Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/922#discussion_r217501779
  
    --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/translator.js
---
    @@ -0,0 +1,93 @@
    +/*
    + *  Licensed to the Apache Software Foundation (ASF) under one
    + *  or more contributor license agreements.  See the NOTICE file
    + *  distributed with this work for additional information
    + *  regarding copyright ownership.  The ASF licenses this file
    + *  to you under the Apache License, Version 2.0 (the
    + *  "License"); you may not use this file except in compliance
    + *  with the License.  You may obtain a copy of the License at
    + *
    + *  http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing,
    + *  software distributed under the License is distributed on an
    + *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + *  KIND, either express or implied.  See the License for the
    + *  specific language governing permissions and limitations
    + *  under the License.
    + */
    +'use strict';
    +
    +/**
    + * Class to translate glv bytecode steps into executable Gremlin-Groovy script
    + */
    +class Translator {
    --- End diff --
    
    I think translators are an established part of TinkerPop at this point. We have them for
Java, Groovy, and Python and I've personally found them to be insanely useful on so many internal
odds/ends. We don't over-publicize them because we don't want to promote "scripts" but I understand
the current need for CosmosDB. 
    
    Anyway, including a Javascript translator is an acceptable addition imo.


---

Mime
View raw message