tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-1774) Gremlin .NET: Support min and max sizes in Connection pool
Date Fri, 07 Sep 2018 07:48:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606800#comment-16606800
] 

ASF GitHub Bot commented on TINKERPOP-1774:
-------------------------------------------

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/903
  
    > Do you see other advantages?
    It allows the client to prime the server with enough requests in order to support maximum
throughput. Considering the multithreaded asynchronous nature of the server, there is far
more advantages in request pipelining than with multiple connections.
    Considering that the server is multithreaded, you can think multiple connections w/o request
pipelining as a system using multiple threads and blocking on each thread; being a single
connection with request pipelining the equivalent of async non-blocking code.
    
    Additionally, supporting the same (or more) throughput with fewer connections has the
advantage of having less memory consumption and being able to support a greater number of
clients.
    
    Regarding the relation of this ticket with TINKERPOP-1775, I think we have 2 options:
    a) We see this change as an incremental improvement (which definitely is) without considering
TINKERPOP-1775.
    b) We try to think now how TINKERPOP-1774 and TINKERPOP-1775 will come into place together,
regardless of which we implement first. I think the ultimate solution would be for the pool
to balance request between connections, and without taking them out of the pool each time
a request/response is issued.
    
    I think we should take the approach in B, otherwise implementing it without thinking of
TINKERPOP-1775 might introduce unnecessary complexity (i.e: a queue of pools that get enqueued
and dequeued all the time).



> Gremlin .NET: Support min and max sizes in Connection pool
> ----------------------------------------------------------
>
>                 Key: TINKERPOP-1774
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1774
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>    Affects Versions: 3.2.7
>            Reporter: Jorge Bay
>            Assignee: Florian Hockmann
>            Priority: Minor
>
> Similar to the java connection pool, we should limit the maximum amount of connections
and start with a minimum number.
> It would also a good opportunity to remove the synchronous acquisitions of {{lock}} in
the pool implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message